Fix new/free mismatch when differentiating delegating constructors. - #1934
Merged
Conversation
For a delegating constructor initializer, DifferentiateCtorInit replaced `_this`'s initializer -- set by BuildThisExpr to malloc and paired with free(_this) -- with an allocating `new ClassTy(args)`, so the new-ed pointer was then handed to free(). Valgrind reports the mismatched deallocation in Gradient/Constructors.C. Emit a placement new into the malloc'd `_this` instead, as the base-initializer path already does, keeping allocation and deallocation malloc/free.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a delegating constructor initializer, DifferentiateCtorInit replaced
_this's initializer -- set by BuildThisExpr to malloc and paired with free(_this) -- with an allocatingnew ClassTy(args), so the new-ed pointer was then handed to free(). Valgrind reports the mismatched deallocation in Gradient/Constructors.C.Emit a placement new into the malloc'd
_thisinstead, as the base-initializer path already does, keeping allocation and deallocation malloc/free.